| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120319202856.GA23606@dhcp-26-207.brq.redhat.com> Date: Mon, 19 Mar 2012 21:28:57 +0100 From: Alexander Gordeev <agordeev@...hat.com> To: Thomas Gleixner <tglx@...utronix.de> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/3] genirq: Clean up IRQ threaded handler exit path On Mon, Mar 19, 2012 at 03:59:05PM +0100, Alexander Gordeev wrote: > The fact that a threaded handler is serving interrupts is encoded in > irq_thread flag explicitly and in the kthread's should_stop flag > implicitly. This fix eliminates the duplicate by checking should_stop > flag only. > > This fix also converts irq_thread flag into a new per process flag that > indicates a kernel thread is actually a IRQ thread handler. As an effect > thread handlers become distinguishable. As a result we can have a single > exit path rather than two. > > Signed-off-by: Alexander Gordeev <agordeev@...hat.com> [...] Thomas, I self-NAK this patch.. I made it before Ido's 7140ea1 commit and blindly posted modified version. Now I see it apparently complicates the code and no consumers of the new irq_thread flag's semantics exist anyway. So no point in this patch. Patches 1 and 3 are unaffected and up to review. -- Regards, Alexander Gordeev agordeev@...hat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists