linux-kernel - Re: [PATCH] gpio: add support for ITE IT87xx Super I/O GPIO, replacing gpio-it8761e.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1332194453.22775.91.camel@saladin.home.flameeyes.eu>
Date:	Mon, 19 Mar 2012 23:00:53 +0100
From:	Diego Elio Pettenò <flameeyes@...meeyes.eu>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Denis Turischev <denis@...pulab.co.il>
Subject: Re: [PATCH] gpio: add support for ITE IT87xx Super I/O GPIO,
 replacing gpio-it8761e.

Il giorno lun, 19/03/2012 alle 21.53 +0000, Grant Likely ha scritto:
> 
> When you move and modify a driver all in one patch, then I don't have
> any way to review what has changed and therefore I cannot apply the
> patch.  At the very least the -M flag must be used with git diff so
> that it can detect the rename, but even better is to also split the
> move and the modification into separate patches. 

The problem is that it's not a move-and-modification: the new driver I
wrote from scratch, basing myself only on the code-flow from the it8761e
previously available (for the one I sent last week), then I re-added the
it8761e-specific features to that one when you asked me to see if I
could merge them back.

So for what it's worth, `git diff -M` won't show you any difference for
this as it won't recognize the new driver as a move-and-modification at
all... the only thing they have in common is the headers' inclusion..

-- 
Diego Elio Pettenò — Flameeyes
http://blog.flameeyes.eu/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/