linux-kernel - linux-next: build failure after merge of the final tree (nfs tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120320192952.ed82031eec8a49cf7da40a8e@canb.auug.org.au>
Date:	Tue, 20 Mar 2012 19:29:52 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Trond Myklebust <trond.myklebust@....uio.no>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Weston Andros Adamson <dros@...app.com>
Subject: linux-next: build failure after merge of the final tree (nfs tree
 related)

Hi Trond,

[This was previously reported as a warning ... but sparc uses -Werr in
more places]

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

In file included from arch/sparc/kernel/sys_sparc32.c:24:0:
include/linux/nfs_fs.h: In function 'nfs_display_fhandle_hash':
include/linux/nfs_fs.h:416:1: error: no return statement in function returning non-void [-Werror=return-type]

Caused by commit d8e0539ebdff ("NFS: add filehandle crc for debug display").

I added the following patch for today:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Tue, 20 Mar 2012 19:26:42 +1100
Subject: [PATCH] nfs: non void functions must return a value

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 include/linux/nfs_fs.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
index 8f27c2e..69ec9cb 100644
--- a/include/linux/nfs_fs.h
+++ b/include/linux/nfs_fs.h
@@ -413,6 +413,7 @@ extern void _nfs_display_fhandle(const struct nfs_fh *fh, const char *caption);
 #else
 static inline u32 nfs_display_fhandle_hash(const struct nfs_fh *fh)
 {
+	return 0;
 }
 static inline void nfs_display_fhandle(const struct nfs_fh *fh,
 				       const char *caption)
-- 
1.7.9.1

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped