linux-kernel - Re: [PATCH precise] powerpc/pmac: Fix SMP kernels on pre-core99 UP machines

Open Source and information security mailing list archives

Message-ID: <CAJL_dMsTD6P_Ff_4u9mWGJhRvVQr2Ph2zAp3Lwfmz6Z8kgptnQ@mail.gmail.com>
Date:	Tue, 20 Mar 2012 10:37:39 +0200
From:	Anca Emanuel <anca.emanuel@...il.com>
To:	Jeremy Kerr <jeremy.kerr@...onical.com>
Cc:	kernel-team@...ts.ubuntu.com, 959959@...s.launchpad.net,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH precise] powerpc/pmac: Fix SMP kernels on pre-core99 UP machines

On Tue, Mar 20, 2012 at 9:27 AM, Jeremy Kerr <jeremy.kerr@...onical.com> wrote:
> From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>
> BugLink: https://bugs.launchpad.net/bugs/959959
>
> The code for "powersurge" SMP would kick in and cause a crash
> at boot due to the lack of a NULL test.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Signed-off-by: Jeremy Kerr <jeremy.kerr@...onical.com>
> Reported-By: Adam Conrad <adconrad@...ntu.com>
> Tested-By: Adam Conrad <adconrad@...ntu.com>
>
> Cherry-picked from upstream commit
> 78c5c68a4cf4329d17abfa469345ddf323d4fd62
>
> ---
>  arch/powerpc/platforms/powermac/smp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c
> index 9b6a820..3394254 100644
> --- a/arch/powerpc/platforms/powermac/smp.c
> +++ b/arch/powerpc/platforms/powermac/smp.c
> @@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = {
>
>  static void __init smp_psurge_setup_cpu(int cpu_nr)
>  {
> -       if (cpu_nr != 0)
> +       if (cpu_nr != 0 || !psurge_start)
>                return;
>
>        /* reset the entry point so if we get another intr we won't
>
> --
> kernel-team mailing list
> kernel-team@...ts.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Why not CC: lkml ?

It is on the stable channel ? Upstream link please ?
Now you understand Greg's concerns about maintaining a stable kernel ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives