linux-kernel - Re: [PATCH 5/8] pinctrl: core device tree mapping table parsing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaxVUCqm-2k0n+Mr_dB-RdxJ3=6TDb_GObTh5TD8ssqzw@mail.gmail.com>
Date:	Tue, 20 Mar 2012 13:21:16 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	B29396@...escale.com, s.hauer@...gutronix.de, dongas86@...il.com,
	shawn.guo@...aro.org, thomas.abraham@...aro.org, tony@...mide.com,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH 5/8] pinctrl: core device tree mapping table parsing support

On Fri, Mar 16, 2012 at 9:54 PM, Stephen Warren <swarren@...dotorg.org> wrote:

> During pinctrl_get(), if the client device has a device tree node, look
> for the common pinctrl properties there. If found, parse the referenced
> device tree nodes, with the help of the pinctrl drivers, and generate
> mapping table entries from them.
>
> During pinctrl_put(), free any results of device tree parsing.
>
> Signed-off-by: Stephen Warren <swarren@...dotorg.org>

Can we have it in a separate file like devicetree.[c|h] and
some stubs in the .h file for platforms that does not select
CONFIG_OF?

This:

+static int register_mappings(struct pinctrl_map const *maps, unsigned num_maps,
+                            bool dup, bool locked)

Instead of making this static, move the prototype to core.h and
use that from devicetree.c.

One rationale: the day after tomorrow we will have to get configs
from ACPI, UEFI and what not.

Apart from that I like the looks of this thing!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/