linux-kernel - Re: [PATCH 2/4] compat: backport work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Mar 2012 06:50:44 -0700
From:	"Luis R. Rodriguez" <mcgrof@...jolero.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	lf_driver_backport@...ts.linux-foundation.org
Subject: Re: [PATCH 2/4] compat: backport work_busy()

On Tue, Mar 20, 2012 at 5:07 AM, Johannes Berg
<johannes@...solutions.net> wrote:
> On Mon, 2012-03-19 at 20:26 -0700, Luis R. Rodriguez wrote:
>> From: "Luis R. Rodriguez" <mcgrof@...jolero.org>
>>
>> Best we can do is just tell the users of we are WORK_BUSY_PENDING
>> for older kernels. The ckmake log:
>
> [...]
>
>> + * Test whether @work is currently pending or running.  There is no
>> + * synchronization around this function and the test result is
>> + * unreliable and only useful as advisory hints or for debugging.
>> + * Especially for reentrant wqs, the pending state might hide the
>> + * running state.
>
> What's this needed for? It seems if it's used only for hints/debugging
> we should not need the function, or possibly simply return some
> pointless combination like -1?

net/bluetooth/hci_core.c:1701:	if (work_busy(&hdev->le_scan))

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/