[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120320160121.GC5684@google.com>
Date: Tue, 20 Mar 2012 09:01:21 -0700
From: Tejun Heo <tj@...nel.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc: glommer@...allels.com, lizf@...fujitsu.com,
containers@...ts.linux-foundation.org, cgroups@...r.kernel.org,
linux-kernel@...r.kernel.org, fweisbec@...il.com, rni@...gle.com,
ctalbott@...gle.com
Subject: Re: [PATCH 07/10] cgroup: remove cgroup_add_file[s]()
On Tue, Mar 20, 2012 at 02:17:51PM +0530, Aneesh Kumar K.V wrote:
> Tejun Heo <tj@...nel.org> writes:
>
> > No controller is using cgroup_add_files[s](). Unexport them, and
> > convert cgroup_add_files() to handle NULL entry terminated array
> > instead of taking count explicitly and continue creation on failure
> > for internal use.
> >
>
> I am planning to use that in the HugeTLB extension of memcg.
>
> http://article.gmane.org/gmane.linux.kernel.mm/75470
>
> We need to have different limit and usage file for different HugeTLB
> page size supported.
Unless you have to alter available files cgroup-by-cgroup, you should
be fine. If you're trying to create different set of files depending
on cgroup, it's confusing - change your interface.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists