linux-kernel - Re: [PATCH 09/10] cgroup: introduce struct cfent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F68AA37.80604@parallels.com>
Date:	Tue, 20 Mar 2012 20:03:03 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<lizf@...fujitsu.com>, <containers@...ts.linux-foundation.org>,
	<cgroups@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<fweisbec@...il.com>, <rni@...gle.com>, <ctalbott@...gle.com>
Subject: Re: [PATCH 09/10] cgroup: introduce struct cfent

On 03/20/2012 08:02 PM, Tejun Heo wrote:
> On Tue, Mar 20, 2012 at 06:05:29PM +0400, Glauber Costa wrote:
>> On 03/17/2012 03:36 AM, Tejun Heo wrote:
>>> +static void cgroup_clear_directory(struct dentry *dir)
>>> +{
>>> +	struct cgroup *cgrp = __d_cgrp(dir);
>>> +
>>> +	while (!list_empty(&cgrp->files))
>>> +		cgroup_rm_file(cgrp, NULL);
>>> +	WARN_ON_ONCE(!list_empty(&dir->d_subdirs));
>>>   }
>>
>>
>> I am hitting this warning here under pretty much normal conditions.
>> You forgot to account for trivial directories like "."
>>
>> I'll send a patch ontop of what you have.
>
> Heh, yeah, I hit that yesterday too and was gonna look into that
> today.  Is the patch coming? :)
>
> Thanks.

I was about to send it together with my proposal for sock memcg, so I'm 
compile testing that under multiple config options just to be sure we're 
fine.

That's more or less what I have, see if you agree. I tried to keep the 
warning itself, because it is valuable...


View attachment "0001-don-t-trigger-warning-when-d_subdirs-is-not-empty.patch" of type "text/x-patch" (1159 bytes)