linux-kernel - Re: [PATCH] USB: gadget driver for LPC32xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Mar 2012 21:56:35 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Roland Stigge <stigge@...com.de>
cc:	linux-usb@...r.kernel.org, <linux-kernel@...r.kernel.org>,
	<w.sang@...gutronix.de>, <kevin.wells@....com>,
	<linux-arm-kernel@...ts.infradead.org>, <arm@...nel.org>,
	<srinivas.bakki@....com>
Subject: Re: [PATCH] USB: gadget driver for LPC32xx

On Mon, 19 Mar 2012, Roland Stigge wrote:

> This patch adds a USB gadget driver.
> 
> Signed-off-by: Roland Stigge <stigge@...com.de>

...

> +static const struct usb_ep_ops lpc32xx_ep_ops = {
> +	.enable		= lpc32xx_ep_enable,
> +	.disable	= lpc32xx_ep_disable,
> +	.alloc_request	= lpc32xx_ep_alloc_request,
> +	.free_request	= lpc32xx_ep_free_request,
> +	.queue		= lpc32xx_ep_queue,
> +	.dequeue	= lpc32xx_ep_dequeue,
> +	.set_halt	= lpc32xx_ep_set_halt,
> +};

You have not implemented the set_wedge method, which is needed for the 
file-storage gadgets.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/