linux-kernel - Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1203192156410.24735-100000@netrider.rowland.org>
Date:	Mon, 19 Mar 2012 22:02:18 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Paul Taysom <taysom@...gle.com>
cc:	Mandeep Singh Baines <msb@...omium.org>, Ted Ts'o <tytso@....edu>,
	Theodore Tso <tytso@...gle.com>, Greg KH <greg@...ah.com>,
	Paul Taysom <taysom@...omium.org>,
	Jens Axboe <axboe@...nel.dk>, Andrew Morton <akpm@...gle.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	<linux-fsdevel@...r.kernel.org>, <stable@...nel.org>
Subject: Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks

On Mon, 19 Mar 2012, Paul Taysom wrote:

> I have rerun my tests without my change on the 3.2.7 kernel and I was
> not able to get it to crash. I even put some code in to do the early
> detection so I didn't have to wait for another thread to stumble
> across the corruption. The way I test is with several flash drivers
> with ext2, ext3, ext4, FAT, and HPFS file systems and just repeatedly
> plug and unplug them. When a flash drive is plugged in with a file
> system, it is automatically mounted.

That's not the right way to test a race like this.  The right way is to 
insert ssleep() calls at some appropriate spots, so that you can force 
the race to come out the way you want every time.

What about the question of resetting the bdi pointer at the same time 
as some other thread is using it?  Have you tested whether Mandeep's 
locking suggestion will prevent problems?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/