linux-kernel - Re: [PATCH] autonuma: release page_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120320211723.GG24602@redhat.com>
Date:	Tue, 20 Mar 2012 22:17:24 +0100
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Hillf Danton <dhillf@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] autonuma: release page_table_lock in scanning pmd

On Tue, Mar 20, 2012 at 08:30:48PM +0800, Hillf Danton wrote:
> Only for unlikely corner case, unlock is added to pair lock.
> 
> Signed-off-by: Hillf Danton <dhillf@...il.com>
> ---
> 
> --- a/mm/autonuma.c	Sat Mar 17 11:01:50 2012
> +++ b/mm/autonuma.c	Tue Mar 20 19:58:44 2012
> @@ -522,7 +522,8 @@ static int knumad_scan_pmd(struct mm_str
>  				spin_unlock(&mm->page_table_lock);
>  				goto out;
>  			}
> -		}
> +		} else
> +			spin_unlock(&mm->page_table_lock);
>  	}
> 
>  	VM_BUG_ON(!pmd_present(*pmd));

I'm impressed by how fast you found these bugs.

Thanks a lot, applied!
Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/