linux-kernel - Re: [RFC]blk: mark discard request sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANejiEW_W7873HYi7v682KDCM+vFhD3-_5t0Br6Zb89wcU5MXQ@mail.gmail.com>
Date:	Wed, 21 Mar 2012 09:01:13 +0800
From:	Shaohua Li <shli@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"axboe@...nel.dk" <axboe@...nel.dk>
Subject: Re: [RFC]blk: mark discard request sync

2012/3/21 Vivek Goyal <vgoyal@...hat.com>:
> On Fri, Mar 16, 2012 at 03:40:14PM +0800, Shaohua Li wrote:
>>
>> Subject: blk: mark discard request sync
>>
>> discard is called in jbd for example. If discard is slowed down, all
>> file operations could be impacted (eg, journal is full). And we always
>> wait for discard to finish. So looks we should mark discard as sync.
>>
>> Signed-off-by: Shaohua Li <shli@...ionio.com>
>
> This one is tricky and I am not sure what's the right thing to do.
>
> Generally the philosophy seems to be that request is sync is somebody
> is waiting on it. To me even on async writes somebody is waiting (either
> file system or a writer which has been throttled). So if we don't do
> async writes in reasonable amount of time, we start getting "task blocked
> for more than 120 seconds" message.
Not just waiting. If jbd is slow and full, things will get crazy.

> Do you have some test cases to show how bad the problem is if we don't
> issue discard as SYNC request.
I came this idea when debugging Holger's discard slow problem, though his
problem isn't related to the issue because he is using noop. I realized this
could be a problem if ioscheduler is cfq. I tested a workload which deletes
a lot of small files. With a fusionio card (changing ioscheduler to
cfq), marking
discard sync gives slightly better performance. For ssd with slow discard, this
might be more significant (I didn't try, no such ssd).

But any way, I haven't too strong reason we should do this, this's why it's RFC.

Thanks,
Shaohua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/