linux-kernel - Re: [PATCH] Disintegrate asm/system.h for Unicore32 [based on ver #3, changed by gxt]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F692FF3.6090305@mprc.pku.edu.cn>
Date:	Wed, 21 Mar 2012 09:33:39 +0800
From:	Guan Xuetao <gxt@...c.pku.edu.cn>
To:	David Howells <dhowells@...hat.com>
CC:	paul.gortmaker@...driver.com, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH] Disintegrate asm/system.h for Unicore32 [based on ver
 #3, changed by gxt]

On 03/20/2012 05:33 PM, David Howells wrote:
> Guan Xuetao<gxt@...c.pku.edu.cn>  wrote:
>
>> Disintegrate asm/system.h for Unicore32. (Compilation successful)
>> The implementation details are not changed, but only splitted.
>> BTW, some codestyles are adjusted.
>>
>> Signed-off-by: David Howells<dhowells@...hat.com>
>> Signed-off-by: Guan Xuetao<gxt@...c.pku.edu.cn>
> Aha!  Much better.  It mostly looks reasonable, apart from one thing.  See the
> attached patch, which I'll roll in if you're happy with it.
That's great. It's just what I want  to do.
> -extern void panic(const char *fmt, ...);
> +/*
> + * Generate a link failure on undefined symbol if the pointer points to a value
> + * of unsupported size.
> + */
> +extern void __xchg_bad_pointer(void)
A semicolon should be added at the end.
>   static inline unsigned long __xchg(unsigned long x, volatile void *ptr,
>   		int size)
> @@ -31,8 +35,8 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr,
>   			: "memory", "cc");
>   		break;
>   	default:
> -		panic("xchg: bad data size: ptr 0x%p, size %d\n",
> -			ptr, size);
> +		__xchg_bad_pointer();
> +		break;
I think  the 'break' sentence is redundant.

Thanks and Regards,
Guan Xuetao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/