linux-kernel - Re: [PATCH v8] sound/soc/lapis: add machine driver for ML7213 Carrier Board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120321161148.GG3226@opensource.wolfsonmicro.com>
Date:	Wed, 21 Mar 2012 16:11:49 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH v8] sound/soc/lapis: add machine driver for ML7213
 Carrier Board

On Wed, Mar 21, 2012 at 10:15:17AM +0900, Tomoya MORINAGA wrote:

> This machine driver is for
> LAPIS Semiconductor ML7213 Carrier Board + ML26124 Reference Board

This looks good but obviously needs the platform before it can be
merged.  One fairly minor thing:

> +	mclkfs = clk / params_rate(hw_params);

> +		bclkfs = 32;

You no longer use either mclkfs or bclkfs so you could just delete the
code that calculates them - the DAI drivers will work this stuff out for
you now so the machine driver doesn't need to.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)