linux-kernel - Re: [PATCH 3/3] xen/x86: Implement x86_apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332356492.16101.102.camel@sbsiddha-desk.sc.intel.com>
Date:	Wed, 21 Mar 2012 12:01:32 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	jwboyer@...hat.com, mingo@...e.hu, hpa@...or.com,
	yinghai@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] xen/x86: Implement x86_apic_ops

On Wed, 2012-03-21 at 12:41 -0400, Konrad Rzeszutek Wilk wrote:
> > > +unsigned int xen_io_apic_read(unsigned apic, unsigned reg)
> > > +{
> > > +	if (reg == 0x1)
> > > +		return 0x00170020;
> > > +	else if (reg == 0x0)
> > > +		return 0x00000000;
> > 
> > For IO-APIC ID register (0), you can probably use the argument 'apic' to
> > set the ID bits in the returned register.
> 
> ok, that would be just
> return 0x0000000 | apic
> 
> right? Since the last 8 bits are the apic value?

It is the most significant 8 bits.

So you need to return (apic << 24);

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/