[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201203221009.05902.heiko@sntech.de>
Date: Thu, 22 Mar 2012 10:08:58 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Axel Lin <axel.lin@...il.com>
Cc: linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>,
Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: gpio-regulator: Set the smallest voltage/current in the specified range
Am Donnerstag, 22. März 2012, 07:08:04 schrieb Axel Lin:
> Do not assume the gpio regulator states map is sorted in any order.
> This patch ensures we always set the smallest voltage/current that falls
> within the specified range.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
nice addition, thanks
Acked-by: Heiko Stuebner <heiko@...ech.de>
> ---
> drivers/regulator/gpio-regulator.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/gpio-regulator.c
> b/drivers/regulator/gpio-regulator.c index 42e1cb1..b728b36 100644
> --- a/drivers/regulator/gpio-regulator.c
> +++ b/drivers/regulator/gpio-regulator.c
> @@ -105,15 +105,15 @@ static int gpio_regulator_set_value(struct
> regulator_dev *dev, int min, int max)
> {
> struct gpio_regulator_data *data = rdev_get_drvdata(dev);
> - int ptr, target, state;
> + int ptr, target, state, best_val = INT_MAX;
>
> - target = -1;
> for (ptr = 0; ptr < data->nr_states; ptr++)
> - if (data->states[ptr].value >= min &&
> + if (data->states[ptr].value < best_val &&
> + data->states[ptr].value >= min &&
> data->states[ptr].value <= max)
> target = data->states[ptr].gpios;
>
> - if (target < 0)
> + if (best_val == INT_MAX)
> return -EINVAL;
>
> for (ptr = 0; ptr < data->nr_gpios; ptr++) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists