linux-kernel - RE: [PATCH] mfd: Remove unused mutex from struct tps65090

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D958900912E20642BCBC71664EFECE3E6DD3127FFC@BGMAIL02.nvidia.com>
Date:	Thu, 22 Mar 2012 14:46:02 +0530
From:	Venu Byravarasu <vbyravarasu@...dia.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Samuel Ortiz <sameo@...ux.intel.com>
Subject: RE: [PATCH] mfd: Remove unused mutex from struct tps65090

Looks good to me.
Acked-by: Venu Byravarasu <vbyravarasu@...dia.com>

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@...il.com]
> Sent: Thursday, March 22, 2012 2:44 PM
> To: linux-kernel@...r.kernel.org
> Cc: Venu Byravarasu; Samuel Ortiz
> Subject: [PATCH] mfd: Remove unused mutex from struct tps65090
> 
> The mutex lock is not used after converting to use regmap, remove it.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/tps65090.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index a66d4df..9a84bda 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -79,7 +79,6 @@ static struct mfd_cell tps65090s[] = {
>  };
> 
>  struct tps65090 {
> -	struct mutex		lock;
>  	struct device		*dev;
>  	struct i2c_client	*client;
>  	struct regmap		*rmap;
> @@ -283,8 +282,6 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
>  	tps65090->dev = &client->dev;
>  	i2c_set_clientdata(client, tps65090);
> 
> -	mutex_init(&tps65090->lock);
> -
>  	if (client->irq) {
>  		ret = tps65090_irq_init(tps65090, client->irq, pdata-
> >irq_base);
>  		if (ret) {
> --
> 1.7.5.4
> 
>