lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.2.02.1203221128260.2542@ionos>
Date:	Thu, 22 Mar 2012 11:32:26 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Alexander Gordeev <agordeev@...hat.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] genirq: Get rid of unneeded force parameter in
 irq_finalize_oneshot()

On Mon, 19 Mar 2012, Alexander Gordeev wrote:

> The only place irq_finalize_oneshot() is called with force parameter set
> is the threaded handler error exit path. But IRQTF_RUNTHREAD is dropped
> at this point and irq_wake_thread() is not going to reset it again,
> since PF_EXITING is set for this thread already. So we will drop the
> thread's bit in threads_oneshot anyway and the force parameter is
> superfluous.

Wrong.

CPU 0				CPU 1

    do_exit()
				check(PF_EXITING)
				set_bit(IRQTF_RUNTHREAD)
				...
    set(PF_EXITING)
    exit_irq_thread()

    if (test_bit(IRQTF_RUNTHREAD))
	goto out;

	-> FAIL

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ