linux-kernel - Re: [PATCH v3 02/12] vfs: move ima_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALLzPKabJQOjYmG8-MWqoQdTc1mKjOCaxy+K6T_ZyvURKLnj6g@mail.gmail.com>
Date:	Thu, 22 Mar 2012 16:23:33 +0200
From:	"Kasatkin, Dmitry" <dmitry.kasatkin@...el.com>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>,
	David Safford <safford@...ux.vnet.ibm.com>,
	Mimi Zohar <zohar@...ibm.com>
Subject: Re: [PATCH v3 02/12] vfs: move ima_file_free before releasing the file

On Wed, Mar 21, 2012 at 8:54 PM, Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:
> ima_file_free(), called on __fput(), currently flags files that have
> changed, so that the file is re-measured.  For appraising a files's
> integrity, the file's hash must be re-calculated and stored in the
> 'security.ima' xattr to reflect any changes.
>
> This patch moves the ima_file_free() call to before releasing the file
> in preparation of ima-appraisal measuring the file and updating the
> 'security.ima' xattr.
>
> Signed-off-by: Mimi Zohar <zohar@...ibm.com>
> Acked-by: Serge Hallyn <serge.hallyn@...ntu.com>

Acked-by: Dmitry Kasatkin <dmitry.kasatkin@...el.com>

> ---
>  fs/file_table.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 20002e3..554161a 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -243,10 +243,10 @@ static void __fput(struct file *file)
>                if (file->f_op && file->f_op->fasync)
>                        file->f_op->fasync(-1, file, 0);
>        }
> +       ima_file_free(file);
>        if (file->f_op && file->f_op->release)
>                file->f_op->release(inode, file);
>        security_file_free(file);
> -       ima_file_free(file);
>        if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL &&
>                     !(file->f_mode & FMODE_PATH))) {
>                cdev_put(inode->i_cdev);
> --
> 1.7.6.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/