linux-kernel - Re: [PATCH] x86, build: remove unused include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F6B6FDB.80507@zytor.com>
Date:	Thu, 22 Mar 2012 11:30:51 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andreas Bießmann <andreas@...ssmann.de>
CC:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	x86@...nel.org, Michal Marek <mmarek@...e.cz>,
	Matt Fleming <matt.fleming@...el.com>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] x86, build: remove unused include

On 03/22/2012 03:17 AM, Andreas Bießmann wrote:
> On Wed, Feb 15, 2012 at 05:49:49PM +0100, Andreas Bießmann wrote:
>> Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for
>> sys/sysmacros.h include but missed to remove the include.
>>
>> Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel
>> on non linux style systems which may not offer sys/sysmacros.h.
>>
>> Signed-off-by: Andreas Bießmann <andreas@...ssmann.de>
>> ---
>>  arch/x86/boot/tools/build.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
>> index 4e9bd6b..52628cd 100644
>> --- a/arch/x86/boot/tools/build.c
>> +++ b/arch/x86/boot/tools/build.c
>> @@ -29,7 +29,6 @@
>>  #include <stdarg.h>
>>  #include <sys/types.h>
>>  #include <sys/stat.h>
>> -#include <sys/sysmacros.h>
>>  #include <unistd.h>
>>  #include <fcntl.h>
>>  #include <sys/mman.h>
>> -- 
> 
> are there any objections against that patch? could anyone take it if not?

An equivalent patch has been in tip:x86/build for a while and was just
pulled upstream by Linus.

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/