linux-kernel - Re: [patch 1/2]block: handle merged discard request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1zkb9uz1t.fsf@sermon.lab.mkp.net>
Date:	Wed, 21 Mar 2012 22:53:02 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Shaohua Li <shli@...nel.org>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Vivek Goyal <vgoyal@...hat.com>, axboe@...nel.dk,
	linux-kernel@...r.kernel.org, neilb@...e.de
Subject: Re: [patch 1/2]block: handle merged discard request

>>>>> "Shaohua" == Shaohua Li <shli@...nel.org> writes:

Shaohua> Yes, this is a problem. But note we already have this problem
Shaohua> with discard request for a long time. The payload has just
Shaohua> (sector, length).  And looks the request finish returns the
Shaohua> transfered data of the payload instead of the discarded
Shaohua> data. Am I missing anything?

Nope, it's broken. But if you check my write same patches you'll see
that I actually return the correct completion size there.

There are several additional commands in the pipeline where the 1:1
mapping between DMA size and block range is invalid. I want to get rid
of the 1:1 assumption in general so we can handle any command without
these evil workarounds.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/