linux-kernel - Re: [PATCH V2] x86: io_apic: Move and reenable irq only when CONFIG_GENERIC_PENDING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Mar 2012 13:46:21 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Alexander Gordeev <agordeev@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] x86: io_apic: Move and reenable irq only when
 CONFIG_GENERIC_PENDING_IRQ=y


* Alexander Gordeev <agordeev@...hat.com> wrote:

> On Fri, Mar 23, 2012 at 01:35:03PM +0100, Ingo Molnar wrote:
> > 
> > * Alexander Gordeev <agordeev@...hat.com> wrote:
> > 
> > > When CONFIG_GENERIC_PENDING_IRQ=n irq move and reenable code 
> > > is never get executed, nor do_unmask_irq variable updates its 
> > > init value. Move the code under CONFIG_GENERIC_PENDING_IRQ 
> > > macro.
> > 
> > It's not clear from the changelog what it does though, and the
> > #ifdefs are quite a mess. Does the patch fix some real bug? Or 
> > does it remove dead code from certain .config variations?
> 
> It just removes a dead code. Can reword if it worth it.

No need to resend, I'll add this detail.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/