linux-kernel - Re: [PATCH RFC] rcu: Limit GP initialization to CPUs that have been online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332478086.5721.17.camel@marge.simpson.net>
Date:	Fri, 23 Mar 2012 05:48:06 +0100
From:	Mike Galbraith <efault@....de>
To:	Dimitri Sivanich <sivanich@....com>
Cc:	paulmck@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] rcu: Limit GP initialization to CPUs that have been
 online

On Thu, 2012-03-22 at 15:24 -0500, Dimitri Sivanich wrote: 
> On Thu, Mar 22, 2012 at 04:35:33PM +0100, Mike Galbraith wrote:

> > > This patch also shows great improvement in the two
> > > rcu_for_each_node_breadth_first() (nothing over 20 usec and most less than
> > > 10 in initial testing).
> > > 
> > > However, there are spinlock holdoffs at the following tracebacks (my nmi
> > > handler does work on the 3.0 kernel):
> > > 
> > > [  584.157019]  [<ffffffff8144c5a0>] nmi+0x20/0x30
> > > [  584.157023]  [<ffffffff8144bc8a>] _raw_spin_lock_irqsave+0x1a/0x30
> > > [  584.157026]  [<ffffffff810c5f18>] force_qs_rnp+0x58/0x170
> > > [  584.157030]  [<ffffffff810c6192>] force_quiescent_state+0x162/0x1d0
> > > [  584.157033]  [<ffffffff810c6c95>] __rcu_process_callbacks+0x165/0x200
> > > [  584.157037]  [<ffffffff810c6d4d>] rcu_process_callbacks+0x1d/0x80
> > > [  584.157041]  [<ffffffff81061eaf>] __do_softirq+0xef/0x220
> > > [  584.157044]  [<ffffffff81454cbc>] call_softirq+0x1c/0x30
> > > [  584.157048]  [<ffffffff810043a5>] do_softirq+0x65/0xa0
> > > [  584.157051]  [<ffffffff81061c85>] irq_exit+0xb5/0xe0
> > > [  584.157054]  [<ffffffff810212c8>] smp_apic_timer_interrupt+0x68/0xa0
> > > [  584.157057]  [<ffffffff81454473>] apic_timer_interrupt+0x13/0x20
> > > [  584.157061]  [<ffffffff8102b352>] native_safe_halt+0x2/0x10
> > > [  584.157064]  [<ffffffff8100adf5>] default_idle+0x145/0x150
> > > [  584.157067]  [<ffffffff810020c6>] cpu_idle+0x66/0xc0
> > 
> > Care to try this?  There's likely a better way to defeat ->qsmask == 0
> > take/release all locks thingy, however, if Paul can safely bail in
> > force_qs_rnp() in tweakable latency for big boxen patch, I should be
> > able to safely (and shamelessly) steal that, and should someone hotplug
> > a CPU, and we race, do the same thing bail for small boxen.
> 
> Tested on a 48 cpu UV system with an interrupt latency test on isolated
> cpus and a moderate to heavy load on the rest of the system.
> 
> This patch appears to take care of all excessive (> 35 usec) RCU-based
> latency in the 3.0 kernel on this particular system for this particular
> setup.  Without the patch, I see many latencies on this system > 150 usec
> (and some > 200 usec).

Figures.  I bet Paul has a better idea though.  Too bad we can't whack
those extra barriers, that would likely wipe RCU from your radar.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/