linux-kernel - On patch "device.h: audit and cleanup users in main include dir"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120324212125.460c89d3@stein>
Date:	Sat, 24 Mar 2012 21:21:25 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org
Subject: On patch "device.h: audit and cleanup users in main include dir"

Hi Paul,

commit 313162d0b83836e2f57e51b9b8650fb4b9c396ea is not 100.00% correct.

--- a/include/linux/firewire.h
+++ b/include/linux/firewire.h
@@ -2,7 +2,6 @@
 #define _LINUX_FIREWIRE_H
 
 #include <linux/completion.h>
-#include <linux/device.h>
 #include <linux/dma-mapping.h>
 #include <linux/kernel.h>
 #include <linux/kref.h>
@@ -68,6 +67,8 @@
 #define CSR_MODEL              0x17
 #define CSR_DIRECTORY_ID       0x20
 
+struct device;
+
 struct fw_csr_iterator {
        const u32 *p;
        const u32 *end;

But struct fw_device and struct fw_unit, defined in include/firewire.h,
incorporate struct device.

Furthermore, the inline function definitions
    fw_device,
    fw_unit,
    fw_unit_get,
    fw_unit_put,
    fw_parent_device
all require definitions from linux/device.h.
-- 
Stefan Richter
-=====-===-- --== ==---
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/