linux-kernel - Re: [PATCH] ACPI: Implement overriding of arbitrary ACPI tables via initrd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQW-dNhZGYdpGEwsUbSG9okPyM-JR50GaASSLvAR0nBt8A@mail.gmail.com>
Date:	Fri, 23 Mar 2012 17:15:37 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Thomas Renninger <trenn@...e.de>
Cc:	eric.piel@...mplin-utc.net, vojcek@...n.pl, dsdt@...gusch.at,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, Lin Ming <ming.m.lin@...el.com>, lenb@...nel.org,
	robert.moore@...el.com, hpa@...or.com
Subject: Re: [PATCH] ACPI: Implement overriding of arbitrary ACPI tables via initrd

On Fri, Mar 23, 2012 at 1:54 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>> --- a/arch/x86/mm/init.c
>> +++ b/arch/x86/mm/init.c
>> @@ -391,6 +391,12 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>>         *   - relocate_initrd()
>>         * So here We can do PAGE_ALIGN() safely to get partial page to be freed
>>         */
>> +#ifdef CONFIG_ACPI_INITRD_TABLE_OVERRIDE
>> +       if (acpi_initrd_offset)
>> +               free_init_pages("initrd memory", start - acpi_initrd_offset,
>> +                               PAGE_ALIGN(end));
>> +       else
>> +#endif
>
> table already get copied to allocated ram, So you don't need to keep
> the portion in initrd range.
>
>>        free_init_pages("initrd memory", start, PAGE_ALIGN(end));
>>  }

oh, i missed it. that is offset

change following would be more clean?

 +#ifdef CONFIG_ACPI_INITRD_TABLE_OVERRIDE
 +       /* offset back to free acpi tables */
 +       if (acpi_initrd_offset)
 +               start -= acpi_initrd_offset,
 +#endif

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/