linux-kernel - Re: [PATCH] regmap: rbtree: Fix register default look-up in sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120324005640.GC3190@opensource.wolfsonmicro.com>
Date:	Sat, 24 Mar 2012 00:56:41 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	linux-kernel@...r.kernel.org, dp@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] regmap: rbtree: Fix register default look-up in sync

On Fri, Mar 23, 2012 at 11:04:57AM +0100, Lars-Peter Clausen wrote:
> The code currently passes the register offset in the current block to
> regcache_lookup_reg. This works fine as long as there is only one block and with
> base register of 0, but in all other cases it will look-up the default for a
> wrong register, which can cause unnecessary register writes. This patch fixes
> it by passing the actual register number to regcache_lookup_reg.
> 
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> Cc: <stable@...r.kernel.org>

Good catch - I'm fairly surprised nobody (including me) noticed it over
the couple of kernel releases it's been there.  Will apply once we've
got an -rc1.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)