linux-kernel - [PATCH] gpio/sodaville: Mark broken due to core irqdomain migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1332576679-6251-1-git-send-email-grant.likely@secretlab.ca>
Date:	Sat, 24 Mar 2012 08:11:19 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	linux-kernel@...r.kernel.org
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	"Hans J. Koch" <hjk@...utronix.de>,
	Torben Hohn <torbenh@...utronix.de>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: [PATCH] gpio/sodaville: Mark broken due to core irqdomain migration

The sodaville driver doesn't build anymore due to the transition to
common irq_domain in the core code.  It needs to be reworked, but
the rework isn't trivial.  Since this is a new driver anyway for
v3.4, mark it as broken now and a fixup patch can re-enable it when
the rework change has been tested.

Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
Cc: Hans J. Koch <hjk@...utronix.de>
Cc: Torben Hohn <torbenh@...utronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
---

Hans,

I'm sorry that I need to do this, but the irqdomain rework broke this
driver. The fixup turns out to be non-trivial so I'm not confident to
just merge it.  I'll send you the draft patch that I have to fix it up
in a separate email.  It will be up to you to test and repost it.
However, the fix doesn't need to wait for v3.5; I'm okay to take a
fixup patch after the merge window closes.

Cheers,
g.

 drivers/gpio/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index dbb1909..dfea1d8 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -419,7 +419,7 @@ config GPIO_ML_IOH

 config GPIO_SODAVILLE
 	bool "Intel Sodaville GPIO support"
-	depends on X86 && PCI && OF
+	depends on X86 && PCI && OF && BROKEN
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
 	help
-- 
1.7.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/