linux-kernel - Re: [PATCH] gpio: ep93xx: Remove unused inline function and useless pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120324170736.285BC3E0A0E@localhost>
Date:	Sat, 24 Mar 2012 17:07:36 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Cc:	linus.walleij@...ricsson.com
Subject: Re: [PATCH] gpio: ep93xx: Remove unused inline function and useless pr_err message

On Wed, 21 Mar 2012 11:13:27 -0700, H Hartley Sweeten <hartleys@...ionengravers.com> wrote:
> Minor removal of an unused inline function and a useless pr_err message.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Cc: Linus Walleij <linus.walleij@...ricsson.com>

Applied, thanks.

g.

> ---
> 
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index 4ca5642..776b772 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -12,8 +12,6 @@
>   *  published by the Free Software Foundation.
>   */
>  
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -
>  #include <linux/init.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> @@ -65,11 +63,6 @@ static void ep93xx_gpio_update_int_params(unsigned port)
>  		EP93XX_GPIO_REG(int_en_register_offset[port]));
>  }
>  
> -static inline void ep93xx_gpio_int_mask(unsigned line)
> -{
> -	gpio_int_unmasked[line >> 3] &= ~(1 << (line & 7));
> -}
> -
>  static void ep93xx_gpio_int_debounce(unsigned int irq, bool enable)
>  {
>  	int line = irq_to_gpio(irq);
> @@ -212,7 +205,6 @@ static int ep93xx_gpio_irq_type(struct irq_data *d, unsigned int type)
>  		handler = handle_edge_irq;
>  		break;
>  	default:
> -		pr_err("failed to set irq type %d for gpio %d\n", type, gpio);
>  		return -EINVAL;
>  	}
>  

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/