linux-kernel - [RFC PATCHSET] perf ui: Small preparation on further UI work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 17:51:31 +0900
From:	Namhyung Kim <namhyung.kim@....com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Pekka Enberg <penberg@...nel.org>
Subject: [RFC PATCHSET] perf ui: Small preparation on further UI work

Hi,

This is my initial work of UI generalization. As we now get GTK2 support on
perf report, improve setup_browser() to handle it properly so that we can
add various UI specific initialization codes to the function. At least, we
need basic error/warning handlers ASAP to see what's going on when an error
occurred, IMHO.

I put new file setup.c under ui directory (not under util/ui) and it may or
may not be compiled depending on the system configuration. I think it'd be
better moving generic UI codes to the directory and TUI specific codes to
ui/tui, and so on, so that the util directory doesn't contain any UI codes.
But before proceeding, I'd like to listen to your opinions :).

Any comments are welcome.
Thanks.

Namhyung Kim (5):
  perf ui: Make setup_browser() generic
  perf ui: Drop arg[cv] arguments from perf_gtk_setup_browser()
  perf ui: Add gtk2 support into setup_browser()
  perf gtk: Rename functions for consistency
  perf ui: Change fallback policy of setup_browser()

 tools/perf/Makefile           |    7 ++++-
 tools/perf/builtin-report.c   |    5 +---
 tools/perf/ui/setup.c         |   44 +++++++++++++++++++++++++++++
 tools/perf/util/cache.h       |   24 +++++++++++-----
 tools/perf/util/gtk/browser.c |   27 +++++++++---------
 tools/perf/util/gtk/gtk.h     |    4 +++
 tools/perf/util/ui/setup.c    |   61 +++++++++++++++-------------------------
 7 files changed, 108 insertions(+), 64 deletions(-)
 create mode 100644 tools/perf/ui/setup.c

-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/