linux-kernel - Re: [PATCH RFC dontapply] kvm_para: add mmio word store hypercall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 13:24:02 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Gleb Natapov <gleb@...hat.com>
Cc:	Avi Kivity <avi@...hat.com>, Joerg Roedel <joerg.roedel@....com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC dontapply] kvm_para: add mmio word store hypercall

On Mon, Mar 26, 2012 at 12:29:21PM +0200, Gleb Natapov wrote:
> > > > +		gpa = hc_gpa(vcpu, a1, a2);
> > > > +		if (!write_mmio(vcpu, gpa, 2, &a0) && run) {
> > > 
> > > What's this && run thing?
> > 
> > I'm not sure - copied this from another other place in emulation:
> > arch/x86/kvm/x86.c:4953:                if (!write_mmio(vcpu, gpa, 2, &a0) && run)
> > 
> What git tree is this from? I think that's the one you added.

Ugh. My mistake. So the answer is this, as I said, this is
on an ancient tree that did not have
112592da0dc2460c95e8a89d0c5657c6a30286aa
I'll remove this check, thanks for pointing this out.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/