linux-kernel - Re: Remove over-broad module alias from zaurus.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 08:49:29 -0400
From:	Dave Jones <davej@...hat.com>
To:	Guan Xin <guanx.bac@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Remove over-broad module alias from zaurus.

On Mon, Mar 26, 2012 at 10:39:48AM +0200, Guan Xin wrote:
 > > On Fri, 17 Jun 2011 20:02:10 -0400, Dave Jones wrote:
 > > This module and a bunch of dependancies are getting loaded on several
 > > of laptops I have (probably picking up the mobile broadband device),
 > > that have nothing to do with zaurus. Matching by class without
 > > any vendor/device pair isn't the right thing to do here, as it
 > > will prevent any other driver from correctly binding to it.
 > > (Or in the absense of a driver, will just waste time & memory by
 > >  unnecessarily loading modules)
 > >
 > > Signed-off-by: Dave Jones <davej@...hat.com>
 > > -	USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM,
 > > -			USB_CDC_PROTO_NONE),
 > > -	.driver_info = (unsigned long) &bogus_mdlm_info,
 > > -}, {
 > >  	/* Motorola MOTOMAGX phones */
 > >  	USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x6425, USB_CLASS_COMM,
 > >  			USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
 > 
 > After removal of this, my Motorola Rokr E6 (22b8:6027) cannot be recognized.
 > Can this be added back with more specific device info, just like the
 > Motorola MOTOMAGX phones?

Yes, just cut-n-paste one of the other entries, change the ID,
make sure it works and send a diff.

	Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/