linux-kernel - Re: [PATCH RFT v2] watchdog: Convert orion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 19:36:24 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Jason Cooper <jason@...edaemon.net>
Cc:	Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org,
	Sylver Bruneau <sylver.bruneau@...glemail.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	linux-watchdog@...r.kernel.org,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Andrew Lunn <andrew@...n.ch>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH RFT v2] watchdog: Convert orion_wdt driver to watchdog
 core

> >  static int __devinit orion_wdt_probe(struct platform_device *pdev)
> > @@ -241,26 +146,28 @@ static int __devinit orion_wdt_probe(struct platform_device *pdev)
> >  	struct resource *res;
> >  	int ret;
> >  
> > -	if (pdata) {
> > -		wdt_tclk = pdata->tclk;
> > -	} else {
> > +	if (!pdata) {
> >  		pr_err("misses platform data\n");
> >  		return -ENODEV;
> >  	}
> 
> Platform data is changing soon with devicetree support (and converting
> to common clock).  Please don't change this if you don't need to.
> 
> Also, I'll include Andrew Lunn in the CC.  He's doing the conversion of
> orion over to common clock, which affects this driver.

Yep,

Once the merge is over and the first -rc kernel is released, i will
post my patches rebased on that. For wdt, clk is no longer in the
platform data.

	 Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/