linux-kernel - Re: [PATCH 02/11 v3] drm/i915/intel_i2c: assign HDMI port D to pin pair 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGS+omAkRiVMJCEK5eyEvWrVEZxCqyjkd3ocNZq=69mC29o-PA@mail.gmail.com>
Date:	Tue, 27 Mar 2012 01:49:51 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Daniel Kurtz <djkurtz@...omium.org>,
	Keith Packard <keithp@...thp.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Chris Wilson <chris@...is-wilson.co.uk>,
	Benson Leung <bleung@...omium.org>,
	Yufeng Shen <miletus@...omium.org>
Subject: Re: [PATCH 02/11 v3] drm/i915/intel_i2c: assign HDMI port D to pin
 pair 6

On Mon, Mar 26, 2012 at 11:08 PM, Daniel Vetter <daniel@...ll.ch> wrote:
>
> On Mon, Mar 26, 2012 at 04:47:11PM +0200, Daniel Vetter wrote:
> > On Mon, Mar 26, 2012 at 10:26:41PM +0800, Daniel Kurtz wrote:
> > > According to i915 documentation [1], "Port D" (DP/HDMI Port D) is
> > > actually gmbus pin pair 6 (gmbus0.2:0 == 110b GPIOF), not 7 (111b).
> > > Pin pair 7 is a reserved pair.
> > >
> > > [1] Documentation for [DevSNB+] and [DevIBX], as found on
> > > http://intellinuxgraphics.org
> > >
> > > Note: the "reserved" and "disabled" pairs do not actually map to a
> > > physical pair of pins, nor GPIO regs and shouldn't be initialized or
> > > used.
> > > Fixing this is left for a later patch.
> > >
> > > This bug has not been noticed for two reasons:
> > >  1) "gmbus" mode is currently disabled - all transfers are actually
> > > using
> > >     "bit-bang" mode which uses the GPIO port 5 (the "HDMI/DPD
> > > CTLDATA/CLK"
> > >     pair), at register 0x5024 (defined as GPIOF i915_reg.h).
> > >     Since this is the correct pair of pins for HDMI1, transfers
> > > succeed.
> >
> > ... this is no longer true on drm-intel-next.
> >
> > >  2) Even if gmbus mode is re-enabled, the first attempted transaction
> > >     will fail because it tries to use the wrong ("Reserved") pin pair.
> > >     However, the driver immediately falls back again to the bit-bang
> > >     method, which correctly uses GPIOF, so again, transfers succeed.
> > >
> > > However, if gmbus mode is re-enabled and the GPIO fall-back mode is
> > > disabled, then reading an attached monitor's EDID fail.
> > >
> > > Signed-off-by: Daniel Kurtz <djkurtz@...omium.org>
> >
> > Otherwise this looks ok to me - I've checked with gen3 Bspec and we seem
> > to indeed have a 1:1 mapping, see "Display Registers", 1.5.3 "GPIO
> > Control
> > Registers", the list right below the heading.
>
> well, scrap that, I've confused myself here a bit. Afaict we don't
> actually use these gmbus ports on earlier chips.
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
> >
> > When resending, can you please add the Bspec reference above?
>
> Can you you instead add a clear reference (Volume, Full Section plus
> Heading Title) for the Snb/Ibx public Bspec.
>
> Thanks, Daneil
> --
> Daniel Vetter
> Mail: daniel@...ll.ch
> Mobile: +41 (0)79 365 57 48

I'm not sure what a "Bspec" is, but here is the documents I used:

[DevSNB+]: http://intellinuxgraphics.org/documentation/SNB/IHD_OS_Vol3_Part3.pdf
Section 2.2.2 lists the 6 gmbus ports (gpio pin pairs):
  [ 5: HDMI/DPD, 4: HDMIB, 3: HDMI/DPC, 2: LVDS, 1: SSC, 0: VGA ]
2.2.2.1 lists the GPIO registers to control these 6 ports.
2.2.3.1 lists the mapping between 5 of these gmbus ports and the 3
Pin_Pair_Select bits (of the GMBUS0 register).  This table is missing
HDMIB (port 101).

[DevIBX]: http://intellinuxgraphics.org/IHD_OS_Vol3_Part3r2.pdf
Section 2.2.2 lists the same 6 gmbus ports plus two 'reserved' gpio ports.
2.2.2.1 lists 8 GPIO registers... however, it says the size of the
block is 6x32, which implies that those 2 reserved GPIO registers
(GPIO_6 & GPIO_7) don't actually exist (or are irrelevant).
2.2.3.1 lists the mapping between the 6 named gmbus ports and the 3
Pin_Pair_Select bits (of the GMBUS0 register).  This table has HDMIB.

HTH,
-Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/