linux-kernel - Re: linux-next: Tree for Mar 26 (usbcore)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 16:06:59 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Greg KH <gregkh@...uxfoundation.org>
cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	<linux-next@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: linux-next: Tree for Mar 26 (usbcore)

On Mon, 26 Mar 2012, Greg KH wrote:

> On Mon, Mar 26, 2012 at 09:58:36AM -0700, Randy Dunlap wrote:
> > On 03/25/2012 09:28 PM, Stephen Rothwell wrote:
> > 
> > > Hi all,
> > > 
> > > Reminder: please do not add stuff destined for v3.5 to linux-next
> > > included trees/branches until after v3.4-rc1 has been released.
> > > 
> > > Changes since 20120323:
> > 
> > 
> > 
> > on x86_64:
> > 
> > ERROR: "utf16s_to_utf8s" [drivers/usb/core/usbcore.ko] undefined!
> > ERROR: "usb_speed_string" [drivers/usb/core/usbcore.ko] undefined!
> > 
> > Full randconfig file is attached.
> 
> Odd, nothing in the usb core has changed in a while in this area,
> although we might have gotten some core dependancies mixed up for random
> configurations like this.

This is puzzling.

	utf16s_to_utf8s is defined in fs/nls/nls_base.c,
	which is built according to CONFIG_NLS (in fs/nls/Makefile),
	which is selected by CONFIG_USB (in drivers/usb/Kconfig).

But the config that Randy attached had CONFIG_USB set to M and 
CONFIG_NLS not set.  How is that possible?

	usb_speed_string is defined in drivers/usb/usb-common.c,
	which is built according to CONFIG_USB_COMMON (in
		drivers/usb/Makefile),
	which defaults to Y if CONFIG_USB_SUPPORT and either
		CONFIG_USB or CONFIG_USB_GADGET is set (in 
		drivers/usb/Kconfig).

The problem here was that CONFIG_USB_SUPPORT isn't set but CONFIG_USB
is set to M.  This used not to be possible, since CONFIG_USB was
defined inside an "if USB_SUPPORT" section.  Maybe that got changed and
needs to be fixed (but
https://git.kernel.org/?p=linux/kernel/git/next/linux-next.git thinks
it's still not possible).  Or maybe Randy's tree is a little out of 
date.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/