linux-kernel - Re: [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F6FF179.5090600@toshiba.co.jp>
Date:	Mon, 26 Mar 2012 13:32:57 +0900
From:	KOBAYASHI Yoshitake <yoshitake.kobayashi@...hiba.co.jp>
To:	Santosh Y <santoshsy@...il.com>
Cc:	James Bottomley <James.Bottomley@...senPartnership.com>,
	linux-scsi@...r.kernel.org, patches@...aro.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	arnd.bergmann@...aro.org, saugata.das@...aro.org,
	dsaxena@...aro.org, stephen.doel@...aro.org, venkat@...aro.org,
	ilho215.lee@...sung.com, nala.la@...sung.com,
	girish.shivananjappa@...aro.org, vishak.g@...sung.com,
	k.rajesh@...sung.com, yejin.moon@...sung.com,
	sreekumar.c@...sung.com, vinholikatti@...il.com,
	linkinjeon@...il.com, michaelc@...wisc.edu
Subject: Re: [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver

> > +        utrdlp[i].response_upiu_length =
> > +                cpu_to_le16(ALIGNED_UPIU_SIZE);

Response UPIU Length(RUL) shows the response UPIU length in Dword.
(JEDEC Standard No.223 6.2.1 UTP Transfer Request Descriptor)
The following will be correct.

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 07ec973..feffe65 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -836,7 +836,7 @@ static void ufshcd_host_memory_configure(struct ufs_hba *hba)
                 utrdlp[i].prd_table_offset =
                                 cpu_to_le16((prdt_offset >> 2));
                 utrdlp[i].response_upiu_length =
-                               cpu_to_le16(ALIGNED_UPIU_SIZE);
+                               cpu_to_le16(ALIGNED_UPIU_SIZE >> 2);

                 hba->lrb[i].utr_descriptor_ptr = (utrdlp + i);
                 hba->lrb[i].ucd_cmd_ptr =

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/