linux-kernel - Re: [PATCH 0/6] firmware_class: Fix problems with usermodehelper test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201203262237.49735.rjw@sisk.pl>
Date:	Mon, 26 Mar 2012 22:37:49 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Saravana Kannan <skannan@...eaurora.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Christian Lamparter <chunkeey@...glemail.com>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	alan@...rguk.ukuu.org.uk,
	Linux PM mailing list <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 0/6] firmware_class: Fix problems with usermodehelper test

On Monday, March 26, 2012, Greg KH wrote:
> On Mon, Mar 26, 2012 at 12:00:34AM +0200, Rafael J. Wysocki wrote:
> > Hi all,
> > 
> > The following series of patches fixes two problems with
> > request_firmware() and request_firmware_nowait() resulting from commit
> > a144c6a6c924aa1da04dd77fb84b89927354fdff
> > 
> >     PM: Print a warning if firmware is requested when tasks are frozen
> > 
> > The first problem is that request_firmware_nowait() may fail if it happens
> > to run in parallel with system suspend.  It should't fail in such situations
> > and that is addressed by the first three patches (that code has been discussed
> > with Linus at al already).
> > 
> > The second issue is that request_firmware() may be called in a thread which
> > isn't related to system suspend and if suspend happens exactly at that time,
> > request_firmware() will fail (and print a scary warning), although it shouldn't.
> > This problem is addressed by the remaining three patches, which are new.
> 
> At first glance, they all look good to me, thanks for doing this work:
> 	Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Thanks!

> I'm guessing this will go in through one of your trees, right?

That's correct.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/