linux-kernel - Re: [PATCH 2/2] enable dumpstack() to printk log level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332723569.2359.16.camel@hebo>
Date:	Mon, 26 Mar 2012 08:59:29 +0800
From:	"he, bo" <bo.he@...el.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	akpm@...ux-foudation.org, mingo@...e.hu, a.p.zijlstra@...llo.nl,
	rusty@...tcorp.com.au, william.douglas@...el.com,
	linux-kernel@...r.kernel.org, yanmin_zhang@...ux.intel.com
Subject: Re: [PATCH 2/2] enable dumpstack() to printk log level

On Fri, 2012-03-23 at 13:22 +0100, Ingo Molnar wrote:
> * he, bo <bo.he@...el.com> wrote:
> 
> > --- a/arch/x86/kernel/dumpstack.c
> > +++ b/arch/x86/kernel/dumpstack.c
> > @@ -177,20 +177,29 @@ void show_stack(struct task_struct *task, unsigned long *sp)
> >  }
Ingo,

Thanks for your kind comments. It's the 1st time for me to send patches to LKML.
There are 2 patches. I sent the 1st one to a wrong address. I will resend the 2 patches.

> >  
> >  /*
> > - * The architecture-independent dump_stack generator
> > + * The architecture-independent dump_stack_log_lvl generator
> 
> I guess it wants to say "architecture-dependent"?
Right. I will change it to architecture-dependent.

> 
> > +	show_trace_log_lvl(NULL, NULL, &stack, bp, log_lvl);
> > +}
> > +EXPORT_SYMBOL(dump_stack_log_lvl);
> 
> this should be a _GPL export.
Yes. I will change it.

> 
> > +}
> > +EXPORT_SYMBOL(dump_stack_log_lvl);
Yes. I will change it.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/