linux-kernel - Re: [PATCH 4/6 OPTION-A version 3] completion: Add new wait_for_completion_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332835919.16159.195.camel@twins>
Date:	Tue, 27 Mar 2012 10:11:59 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	linux-security-module@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Paul Turner <pjt@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	NFS list <linux-nfs@...r.kernel.org>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	"Bhamare, Sachin" <sbhamare@...asas.com>,
	David Howells <dhowells@...hat.com>,
	Eric Paris <eparis@...hat.com>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Kay Sievers <kay.sievers@...y.org>,
	James Morris <jmorris@...ei.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"keyrings@...ux-nfs.org" <keyrings@...ux-nfs.org>
Subject: Re: [PATCH 4/6 OPTION-A version 3] completion: Add new
 wait_for_completion_timeout_state

On Mon, 2012-03-26 at 19:33 -0700, Boaz Harrosh wrote:
> +int __sched
> +wait_for_completion_timeout_state(struct completion *x,
> +                                 unsigned long timeout, int state)
> +{
> +       long t;
> +       int ret;
> +
> +       if (!timeout)
> +               timeout = MAX_SCHEDULE_TIMEOUT;
> +
> +       switch (state) {
> +       default:
> +               WARN_ON_ONCE(1);
> +               /* fall through */
> +       case 0:
> +               state = TASK_UNINTERRUPTIBLE;
> +               break;
> +       case TASK_KILLABLE:
> +       case TASK_INTERRUPTIBLE:
> +               break;
> +       }

Don't do this, just pass in TASK_UNINTERRUPTIBLE (or TASK_NORMAL)
whatever you like/need.

Don't fudge it by over-loading TASK_RUNNING (aka. 0).

> +       t = wait_for_common(x, timeout, state);
> +       if (likely(t > 0)) {
> +               ret = 0;
> +       } else  {
> +               if (t < 0)
> +                       ret = t;
> +               else
> +                       ret = -ETIMEDOUT;
> +       }
> +       return ret;

Again, why wreck an entirely reasonable return code and break with the
rest of the API.

> +}
> +EXPORT_SYMBOL(wait_for_completion_timeout_state); 


So I'm fine with adding wait_for_completion_timeout_state(), but make it
look and smell like wait_for_completion_timeout() and use a proper
state, like wake_up_state().

IOW:

unsigned long __sched 
wait_for_completion_timeout_state(struct completion *x, 
				  unsigned long timeout,
				  unsigned int state)
{
	return wait_for_common(x, timeout, state);
}
EXPORT_SYMBOL(wait_for_completion_timeout_state);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/