linux-kernel - Re: hpet_disable() call sites

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1203271457460.2542@ionos>
Date:	Tue, 27 Mar 2012 14:58:58 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jan Beulich <JBeulich@...e.com>
cc:	mingo@...e.hu, hirofumi@...l.parknet.co.jp,
	linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: hpet_disable() call sites

On Tue, 27 Mar 2012, Jan Beulich wrote:
> up kernel has a problem if the HPET is in an unexpected state, in
> particular preventing "normal" timer interrupts from occurring (which
> was in particular found to be the case during kdump attempts after
> Xen was running).

What's Xen doing special with the hpet ?
 
> Is there any reason why hpet_disable() should not also be called
> from (or some equivalent action be taken, perhaps including clearing
> certain bits in the individual counters' configuration registers, which
> are apparently - but perhaps wrongly - implied to be clear in e.g.
> hpet_set_mode(), in) hpet_enable()?

No, there is no particular reason why we don't clear those registers.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/