linux-kernel - Re: [PATCH 2/2] m2p_find_override: use list_for_each_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120327142654.GA30655@phenom.dumpdata.com>
Date:	Tue, 27 Mar 2012 10:26:55 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
Cc:	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com
Subject: Re: [PATCH 2/2] m2p_find_override: use list_for_each_entry_safe

On Tue, Mar 27, 2012 at 02:52:44PM +0100, Stefano Stabellini wrote:
> Use list_for_each_entry_safe and remove the spin_lock acquisition in
> m2p_find_override.

So this would allow us to get stale entries. Is that OK?

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> ---
>  arch/x86/xen/p2m.c |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
> index 1b267e7..7ed8cc3 100644
> --- a/arch/x86/xen/p2m.c
> +++ b/arch/x86/xen/p2m.c
> @@ -809,21 +809,17 @@ struct page *m2p_find_override(unsigned long mfn)
>  {
>  	unsigned long flags;
>  	struct list_head *bucket = &m2p_overrides[mfn_hash(mfn)];
> -	struct page *p, *ret;
> +	struct page *p, *t, *ret;
>  
>  	ret = NULL;
>  
> -	spin_lock_irqsave(&m2p_override_lock, flags);
> -
> -	list_for_each_entry(p, bucket, lru) {
> +	list_for_each_entry_safe(p, t, bucket, lru) {
>  		if (page_private(p) == mfn) {
>  			ret = p;
>  			break;
>  		}
>  	}
>  
> -	spin_unlock_irqrestore(&m2p_override_lock, flags);
> -
>  	return ret;
>  }
>  
> -- 
> 1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/