| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120327175921.GB4299@andromeda.dapyr.net> Date: Tue, 27 Mar 2012 13:59:21 -0400 From: Konrad Rzeszutek Wilk <konrad@...nok.org> To: Stefano Stabellini <stefano.stabellini@...citrix.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, "xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [Xen-devel] [PATCH 2/2] m2p_find_override: use list_for_each_entry_safe On Tue, Mar 27, 2012 at 05:37:07PM +0100, Stefano Stabellini wrote: > On Tue, 27 Mar 2012, Konrad Rzeszutek Wilk wrote: > > On Tue, Mar 27, 2012 at 02:52:44PM +0100, Stefano Stabellini wrote: > > > Use list_for_each_entry_safe and remove the spin_lock acquisition in > > > m2p_find_override. > > > > So this would allow us to get stale entries. Is that OK? > > I think it is reasonable. > In practice we should never get an m2p_find_override call looking for an > entry that we are about to add/delete. Why don't you add that in the comment and also fix: /home/konrad/ssd/linux/arch/x86/xen/p2m.c: In function ‘m2p_find_override’: /home/konrad/ssd/linux/arch/x86/xen/p2m.c:810: warning: unused variable ‘flags’ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@...ts.xen.org > http://lists.xen.org/xen-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists