[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201203280047.33501.rjw@sisk.pl>
Date: Wed, 28 Mar 2012 00:47:33 +0200
From: "Rafael J. Wysocki" <rjw@...k.pl>
To: Bojan Smojver <bojan@...ursive.com>
Cc: linux-kernel@...r.kernel.org,
Linux PM mailing list <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v5]: Hibernation: lower/better control the amount of pages used for buffering
On Wednesday, March 28, 2012, Bojan Smojver wrote:
> On Wed, 2012-03-28 at 00:41 +0200, Rafael J. Wysocki wrote:
> > If you define a macro, please use capital letters in the name. Also,
> > the parentheses aren't necessary I think.
> >
> > Perhaps it would be better to use a static inline function instead?
>
> Hmm, was just following the nr_free_pages() definition in swap.h:
>
> /* Definition of global_page_state not available yet */
> #define nr_free_pages() global_page_state(NR_FREE_PAGES)
>
> Still no good?
Not really, that should be a static inline too. :-)
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists