linux-kernel - Re: [RFC] Remove most all #define pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F72BD4F.9020305@ladisch.de>
Date:	Wed, 28 Mar 2012 09:27:11 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Joe Perches <joe@...ches.com>
CC:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jason Baron <jbaron@...hat.com>,
	Jim Cromie <jim.cromie@...il.com>, Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [RFC] Remove most all #define pr_fmt(fmt) lines

Joe Perches wrote:
> With this change, objects like drivers/regulator/core.o
> are prefixed with "core: ".  This is somewhat senseless
> and may prompt Makefile changes to make the prefixes for
> some objects more sensible.
>
> For example, modifying the Makefile to bundle objects
> together with a specific name can change the prefixes.
> Here the prefix becomes "regulator: "
>
> +++ b/drivers/regulator/Makefile
>
> +regulator-y := core.o dummy.o fixed-helper.o
> +regulator-objs := $(regulator-y)
>
> -obj-$(CONFIG_REGULATOR) += core.o dummy.o fixed-helper.o
> +obj-$(CONFIG_REGULATOR) += regulator.o
>
> ------------------
>
> Any objections or other suggestions/improvements?

Instead of doing a Makefile change that has no _obvious_ connection with
printk, wouldn't it be better to just define pr_fmt with "regulator: "?


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/