linux-kernel - RE: [PATCH v2] regulator: i.MX35-PDK Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4875438356E7CA4A8F2145FCD3E61C0B2CC34CAD22@MEP-EXCH.meprolight.com>
Date:	Wed, 28 Mar 2012 14:20:27 +0200
From:	Alex Gershgorin <alexg@...rolight.com>
To:	Fabio Estevam <festevam@...il.com>
CC:	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"fabio.estevam@...escale.com" <fabio.estevam@...escale.com>,
	"broonie@...nsource.wolfsonmicro.com" 
	<broonie@...nsource.wolfsonmicro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2] regulator: i.MX35-PDK Add regulator support

Hi Fabio,

Thanks for you comments,

On Wed, Mar 28, 2012 at 8:52 AM, Alex Gershgorin <alexg@...rolight.com> wrote:
> This version rebased for v3.4, also removes ranges from regulators
> who do not have consumers and adds consumers for same regulators.

> > In your subject: prefix it with "ARM" as this patch should go via the arm tree.

> > Also, do not put comments about kernel version in the commit log.
> > If you want to talk about kernel version/patch history you can do so
> > below the --- line.

I will take note of this 
...
> +static struct regulator_consumer_supply vcam_consumers[] = {
> +       /* sgtl5000 */
> +       REGULATOR_SUPPLY("VDDA", "1-000a"),

> > This should be "0-000a" instead.

oops... I will correct this 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/