linux-kernel - Re: [PATCH] sysrq: Use SEND_SIG_FORCED instead of force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120328205254.GA6930@redhat.com>
Date:	Wed, 28 Mar 2012 22:52:54 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Cox <alan@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysrq: Use SEND_SIG_FORCED instead of force_sig()

On 03/26, Andrew Morton wrote:
>
> > --- a/drivers/tty/sysrq.c
> > +++ b/drivers/tty/sysrq.c
> > @@ -329,7 +329,7 @@ static void send_sig_all(int sig)
> >  		if (is_global_init(p))
> >  			continue;
> >
> > -		force_sig(sig, p);
> > +		do_send_sig_info(sig, SEND_SIG_FORCED, p, true);
> >  	}
> >  	read_unlock(&tasklist_lock);
> >  }
>
> It's unclear how serious this race is (I'm guessing "not very"),

Well yes, I think that the problems are not very serious.

> but
> this patch looks like 3.3 material anyway, yes?

No, this depends on 629d362b9950166c6fac2aa8425db34d824bb043
"signal: give SEND_SIG_FORCED more power to beat SIGNAL_UNKILLABLE".

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/