linux-kernel - Re: [PATCH 2/6] trace: add support for 32 bit compat syscalls on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL26m8JfVekNQC75dSmH+JDFwATdGYjyV-GBx+KrbCSeW-6V2Q@mail.gmail.com>
Date:	Wed, 28 Mar 2012 14:10:23 -0700
From:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	David Sharp <dhsharp@...gle.com>,
	Justin Teravest <teravest@...gle.com>,
	Laurent Chavey <chavey@...gle.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Michael Davidson <md@...gle.com>
Subject: Re: [PATCH 2/6] trace: add support for 32 bit compat syscalls on x86_64

On Mon, Mar 26, 2012 at 9:49 PM, H. Peter Anvin <hpa@...or.com> wrote:
> On 03/26/2012 11:39 AM, Vaibhav Nagarnaik wrote:
>> +/*
>> + * syscall metadata for 32 bit compatible system calls
>> + *
>> + * The metadata entries are in the same order as the system call table
>> + * but this is just to make it easier to check them for completeness
>> + * and correctness.
>> + */
>> +
>> +COMPAT_SYSCALL_METADATA0(restart_syscall)
>> +COMPAT_SYSCALL_METADATA1(exit, int, error_code)
>   [...]
>> +COMPAT_SYSCALL_METADATA5(recvmmsg, int, fd, struct mmsghdr __user *, mmsg, unsigned int, vlen, unsigned int, flags, struct timespec __user *, timeout)
>
>> +/*
>> + * This is truly horrible.
>
> Yes, it is.  How on Earth do you expect the above to ever be maintained?

You are right. I found that I can just reuse the SYSCALL_DEFINEx macro
to define the compat syscall metadata. I am sending the new patch, can
you take a look again?


Thanks


Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/