linux-kernel - Re: [PATCH v4] Ethernet driver for the WIZnet W5300 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120327.223545.1996930432677091672.davem@davemloft.net>
Date:	Tue, 27 Mar 2012 22:35:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	msink@...monline.ru
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	joe@...ches.com, eric.dumazet@...il.com
Subject: Re: [PATCH v4] Ethernet driver for the WIZnet W5300 chip

From: Mike Sinkovsky <msink@...monline.ru>
Date: Mon, 26 Mar 2012 15:07:56 +0600

> +/*
> + * Frame size is hardwired to 1514 bytes (including header),
> + *  => MTU for 802.1Q frames must be set to 1500-4 = 1496
> + */
> +#define W5300_HARD_MTU		1500

I've told you that you must set the VLAN challenged feature flag
(NETIF_F_VLAN_CHALLENGED) for devices which have this restriction.

Just set that, and remove this comment, since the feature bit setting
documents this restriction fully and perfectly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/