linux-kernel - RE: [PATCH net-next 1/5] r8169: modify pll power function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B353B7C4530143B29686566C4F883487@realtek.com.tw>
Date:	Wed, 28 Mar 2012 10:52:24 +0800
From:	hayeswang <hayeswang@...ltek.com>
To:	'Francois Romieu' <romieu@...zoreil.com>
CC:	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 1/5] r8169: modify pll power function

 Francois Romieu [mailto:romieu@...zoreil.com] 
> Sent: Wednesday, March 28, 2012 6:54 AM
> To: Hayeswang
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net-next 1/5] r8169: modify pll power function
> 
> Hayes Wang <hayeswang@...ltek.com> :
> > Adjust r810x_pll_power_down, r810x_pll_power_up, and 
> r8168_pll_power_up.
> > Always power up device during rtl_open.
> > For r810x, turn off more power when the WOL is disabled.
> 
> Would the "Always power up" part qualify as a "fix something" change ?
> 

I don't see any issue about this yet. It seems to be reasonable to make suer the
device would work when the open is called no matter the power is turned off
before or not. 

Best Regards,
Hayes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/