linux-kernel - Re: [PATCH] kvm-amd: Auto-load on CPUs with SVM.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120329070336.GA11227@leaf>
Date:	Thu, 29 Mar 2012 00:03:36 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH] kvm-amd: Auto-load on CPUs with SVM.

On Thu, Mar 29, 2012 at 10:33:25AM +0400, Michael Tokarev wrote:
> On 28.03.2012 22:32, Josh Triplett wrote:
> > Enable x86 feature-based autoloading for the kvm-amd module on CPUs
> > with X86_FEATURE_SVM.
> > 
> > Signed-off-by: Josh Triplett <josh@...htriplett.org>
> 
> It appears to work fine on my amd boxen.

Thanks for testing it.  Can I interpret that as a Tested-by/Acked-by?

> The only problem
> is that I've no idea when it will be possible to finally
> disable the init script (shipped in Debian and other distros)
> to load the module based on /proc/cpuinfo contents.  It will
> do nothing on kernels with this (or kvm-intel) change applied,
> but we still need to support older kernels without that feature... :)

Each stable release of Debian has a specific minimum kernel version that
it supports, typically determined by the requirements of packages such
as udev.  As far as I know, the next stable release will ship with 3.2,
and I don't think the necessary infrastructure exists in 3.2 to backport
this patch (though I'd love to hear otherwise if it does), so that
release will probably need to include the init script.  However, the
next release should have no problem safely dropping it and requiring a
sufficiently new kernel.

In unstable (after the release), qemu-kvm could just go ahead and
drop the script with a NEWS.Debian entry telling people to add the
necessary module to /etc/modules if they have an older kernel.

> Josh, and I'm sure you will be the first who'll file a bugreport
> against qemu-kvm in Debian requesting the startup script to be
> removed!.. ;))

I don't know where you could possibly get that idea. ;)

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/