linux-kernel - Re: [PATCH] staging/vme: Fix module parameters in next-20120323

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F74196C.2030206@ge.com>
Date:	Thu, 29 Mar 2012 09:12:28 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	Gerard Snitselaar <dev@...tselaar.org>
CC:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH] staging/vme: Fix module parameters in next-20120323

On 23/03/12 10:21, Gerard Snitselaar wrote:
> loopback should be declared bool, and variant probably shouldn't be
> const.
> 
> Signed-off-by: Gerard Snitselaar <dev@...tselaar.org>

Looks good, thanks,

Acked-by: Martyn Welch <martyn.welch@...com>

> ---
>  drivers/staging/vme/devices/vme_pio2_core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c
> index 9fedc44..573c800 100644
> --- a/drivers/staging/vme/devices/vme_pio2_core.c
> +++ b/drivers/staging/vme/devices/vme_pio2_core.c
> @@ -35,10 +35,10 @@ static int vector[PIO2_CARDS_MAX];
>  static int vector_num;
>  static int level[PIO2_CARDS_MAX];
>  static int level_num;
> -static const char *variant[PIO2_CARDS_MAX];
> +static char *variant[PIO2_CARDS_MAX];
>  static int variant_num;
>  
> -static int loopback;
> +static bool loopback;
>  
>  static int pio2_match(struct vme_dev *);
>  static int __devinit pio2_probe(struct vme_dev *);


-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@...com                  | VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/